imay commented on a change in pull request #1598: Time zone related be function
URL: https://github.com/apache/incubator-doris/pull/1598#discussion_r312797978
##########
File path: be/src/runtime/datetime_value.cpp
##########
@@ -1524,43 +1524,42 @@ bool DateTimeValue::date_add_interval(const
TimeInterval& interval, TimeUnit uni
return true;
}
-int DateTimeValue::unix_timestamp() const {
- int64_t days = daynr() - calc_daynr(1970, 1, 1);
- if (days < 0) {
+int64_t DateTimeValue::unix_timestamp(const std::string& timezone) const {
Review comment:
I think you should return a bool value if timezone is not valid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
