imay commented on a change in pull request #1598: Time zone related be function
URL: https://github.com/apache/incubator-doris/pull/1598#discussion_r312796878
##########
File path: be/src/runtime/datetime_value.h
##########
@@ -332,9 +333,9 @@ class DateTimeValue {
// Add interval
bool date_add_interval(const TimeInterval& interval, TimeUnit unit);
- int unix_timestamp() const;
+ int64_t unix_timestamp(const std::string& timezone) const;
Review comment:
add some comments for these two functions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
