gaodayue commented on a change in pull request #1633: add zone map page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r314974896
##########
File path: be/src/olap/field.h
##########
@@ -210,6 +204,11 @@ class Field {
_type_info->shallow_copy(dst, src);
}
+ // copy filed content from src to dest without nullbyte
+ inline void copy_content(char* dest, const char* src, Arena* arena) const {
Review comment:
Seems like it's just the arena version of `deep_copy_content`. Can we rename
it to `deep_copy_content`? The same applies to TypeInfo, i.e, renaming
`TypeInfo.copy_with_arena` to `TypeInfo.deep_copy`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
