gaodayue commented on a change in pull request #1633: add zone map page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315566904
##########
File path: be/src/olap/rowset/segment_v2/column_writer.cpp
##########
@@ -142,8 +156,20 @@ Status ColumnWriter::_append_data(const uint8_t** ptr,
size_t num_rows) {
_null_bitmap_builder->add_run(false, num_written);
}
- // TODO(zc): update statistics for this page
-
+ if (_opts.need_zone_map) {
+ for (int i = 0; i < num_written; ++i) {
+ // TODO(hkp): optimize can be done here to reduce memcpy when
the column is sorted
+ if (!_page_min_value->is_null()
+ &&
_page_min_value->field()->compare(_page_min_value->cell_ptr(), start_ptr) > 0) {
Review comment:
when input contains null, `!_page_min_value->is_null()` is false, which
leads to the real not-null min value not being recorded
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
