imay commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524728679 > > I see that in schema_chage.cpp you assign need_ordered_result to true here, which I think it should be false? > > This is to keep the behavior consistent with old code, where reader for non-QUERY task always returns ordered rows, see [here](https://github.com/apache/incubator-doris/pull/1698/files#diff-01d989708840f3c2b8acf4103d1bff94L60) I see, you are right. Old code actually do merge for schema change even if it set `preaggregattion` true.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
