kangpinghuang commented on a change in pull request #1678: Add rowset id
generator to FE and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318366359
##########
File path: be/src/olap/rowset/rowset_meta.h
##########
@@ -71,12 +74,15 @@ class RowsetMeta {
return ret;
}
- int64_t rowset_id() const {
- return _rowset_meta_pb.rowset_id();
+ RowsetId rowset_id() const {
+ return _rowset_id;
}
- void set_rowset_id(int64_t rowset_id) {
- _rowset_meta_pb.set_rowset_id(rowset_id);
+ void set_rowset_id(RowsetId rowset_id) {
Review comment:
```suggestion
void set_rowset_id(const RowsetId& rowset_id) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
