kangpinghuang commented on a change in pull request #1678: Add rowset id
generator to FE and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318366159
##########
File path: be/src/olap/rowset/beta_rowset.cpp
##########
@@ -26,7 +26,7 @@
namespace doris {
std::string BetaRowset::segment_file_path(const std::string& dir, RowsetId
rowset_id, int segment_id) {
Review comment:
```suggestion
std::string BetaRowset::segment_file_path(const std::string& dir, const
RowsetId& rowset_id, const int segment_id) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
