EmmyMiao87 commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318419537
##########
File path: fe/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java
##########
@@ -112,27 +109,31 @@ public static BrokerLoadJob fromLoadStmt(LoadStmt stmt,
String originStmt) throw
if (db == null) {
throw new DdlException("Database[" + dbName + "] does not exist");
}
- // check data source info
- LoadJob.checkDataSourceInfo(db, stmt.getDataDescriptions(),
EtlJobType.BROKER);
// create job
try {
BrokerLoadJob brokerLoadJob = new BrokerLoadJob(db.getId(),
stmt.getLabel().getLabelName(),
-
stmt.getBrokerDesc(), stmt.getDataDescriptions(),
- originStmt);
+ stmt.getBrokerDesc(), originStmt);
brokerLoadJob.setJobProperties(stmt.getProperties());
- brokerLoadJob.setDataSourceInfo(db, stmt.getDataDescriptions());
+ brokerLoadJob.checkAndDataSourceInfo(db,
stmt.getDataDescriptions());
Review comment:
`checkAnd` ?? Maybe `checkAndCreate` is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
