EmmyMiao87 commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319757282
##########
File path: fe/src/main/java/org/apache/doris/analysis/DataDescription.java
##########
@@ -65,34 +67,43 @@
public class DataDescription {
private static final Logger LOG =
LogManager.getLogger(DataDescription.class);
public static String FUNCTION_HASH_HLL = "hll_hash";
- private static final List<String> hadoopSupportFunctionName =
Arrays.asList("strftime", "time_format",
+ private static final List<String> HADOOP_SUPPORT_FUNCTION_NAMES =
Arrays.asList(
+ "strftime",
+ "time_format",
"alignment_timestamp",
- "default_value", "md5sum",
- "replace_value", "now",
- "hll_hash");
+ "default_value",
+ "md5sum",
+ "replace_value",
+ "now", "hll_hash",
Review comment:
per function per line？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
