imay commented on a change in pull request #1737: Unify the msg of 'Memory
exceed limit'
URL: https://github.com/apache/incubator-doris/pull/1737#discussion_r319941741
##########
File path: be/src/runtime/buffered_block_mgr.cpp
##########
@@ -76,9 +77,9 @@ Status BufferedBlockMgr::get_new_block(Block** block,
int64_t len) {
new_block->_buffer_desc->block = new_block;
*block = new_block;
- if (UNLIKELY(_state->instance_mem_tracker()->any_limit_exceeded())) {
- return Status::MemoryLimitExceeded("Memory limit exceeded");
- }
+ std::stringstream msg;
+ msg << "Buffered block mgr, while getting new block";
+ RETURN_IF_LIMIT_EXCEEDED(_state, msg.str());
Review comment:
No need to use stringstream
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
