imay commented on a change in pull request #1737: Unify the msg of 'Memory
exceed limit'
URL: https://github.com/apache/incubator-doris/pull/1737#discussion_r319941135
##########
File path: be/src/exec/sort_node.cpp
##########
@@ -146,8 +146,9 @@ Status SortNode::sort_input(RuntimeState* state) {
RETURN_IF_ERROR(child(0)->get_next(state, &batch, &eos));
RETURN_IF_ERROR(_sorter->add_batch(&batch));
RETURN_IF_CANCELLED(state);
- RETURN_IF_LIMIT_EXCEEDED(state,
- "Sort node was getting next from the child.");
+ std::stringstream msg;
+ msg << "Sort, while getting next from the child.";
+ RETURN_IF_LIMIT_EXCEEDED(state, msg.str());
Review comment:
```suggestion
RETURN_IF_LIMIT_EXCEEDED(state, "Sort, while getting next from the
child.");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
