> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, July 24, 2014 4:20 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet > classification type > > 2014-07-24 08:14, Zhang, Helin: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > 2014-07-24 14:42, Helin Zhang: > > > > For better understanding, 'PCTYPE' was added to the name of i40e > > > > RSS shift macros. > > > > > > > > Signed-off-by: Helin Zhang <helin.zhang at intel.com> > > > > > > > -#define ETH_RSS_NONF_IPV4_UDP_SHIFT 31 > > > > +#define ETH_PCTYPE_NONF_IPV4_UDP 31 > > > > > > Why is it clearer? I don't understand what means PCTYPE. > > > > It is 'packet classification type' defined in data sheet, and widely used. > > Widely used? No it seems to be an i40e naming. > Which datasheet are you pointing?
Sorry, it is widely used in i40e. That might not so widely for the whole DPDK. The datasheet I mentioned is the Intel(r) 40G NIC datasheet. > > > It is not just for RSS only, it can be used for flow director possibly. > > That's why I think it would be better to rename it with PCTYPE names. > > At least, you should add a comment in the code to explain the meaning. OK, good comments! > > Thank you > -- > Thomas
