> -----Original Message----- > From: Matthew Hall [mailto:mhall at mhcomputing.net] > Sent: Thursday, July 24, 2014 4:15 PM > To: Thomas Monjalon; Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions > > If no reboot of the card is needed then it's probably better to add it to one > of > the ethtool style APIs... > -- > Sent from my mobile device. > > On July 24, 2014 1:07:37 AM PDT, Thomas Monjalon > <thomas.monjalon at 6wind.com> wrote: > >2014-07-24 01:01, Matthew Hall: > >> On Thu, Jul 24, 2014 at 09:59:23AM +0200, Thomas Monjalon wrote: > >> > Is it really a good idea to configure this kind of thing at build > >time? > >> > Maybe yes, I'm not sure. > >> > >> Whether it's safe to set at runtime probably depends what happens to > >the card > >> if it gets changed. Do you have to reset the card or the port? Or is > >it OK if > >> it's more dynamic? > > > >No, we can change configuration with rte_eth_dev_configure() before > >initializing port. So it is truly configurable. > >Requiring recompilation means it's not really configurable between 2 > >runs. > >And it breaks binary packaging for Linux distributions. > > > >Many things in DPDK are configured at build time. But we should wonder > >if it's really a good design.
Hi Thomas, Matt Good points! Thank you guys! Regards, Helin
