Hi Jijiang, On 11/27/2014 06:03 PM, Jijiang Liu wrote: > /** Tell the NIC it's an IPv4 packet. Required for L4 checksum offload or > TSO. */ > #define PKT_TX_IPV4 PKT_RX_IPV4_HDR > > /** Tell the NIC it's an IPv6 packet. Required for L4 checksum offload or > TSO. */ > #define PKT_TX_IPV6 PKT_RX_IPV6_HDR
The description still does not match what we discussed. Either we have PKT_TX_IPV4 meaning "packet is IPv4 without requiring IP cksum offload", or "packet is IPv4". I prefer the second one, but whatever the choice is, the comments must be coherent. > -#define PKT_TX_VLAN_PKT (1ULL << 55) /**< TX packet is a 802.1q VLAN > packet. */ > +/** Outer IP cksum of TX pkt. computed by NIC for tunneling packet */ > +#define PKT_TX_OUTER_IP_CKSUM (1ULL << 58) > + > +/** Tell the NIC it's an outer IPv6 packet for tunneling packet.*/ > +#define PKT_TX_OUTER_IPV6 (1ULL << 59) I think we should have the same flags with the same meanings for inner and outer: - PKT_TX_IPV4, PKT_TX_IP_CKSUM, PKT_TX_IPV6 - PKT_TX_OUTER_IPV4, PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IPV6 In your patch there is no PKT_TX_OUTER_IPV4 flag. Regards, Olivier
