> -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Friday, November 28, 2014 11:19 AM > To: Ananyev, Konstantin; Liu, Jijiang; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and > change three fields > > Hi Konstantin, > > On 11/28/2014 12:13 PM, Ananyev, Konstantin wrote: > >>> For the upper layer, I think there would be no big difference, what ways > >>> we will choose. > >> > >> I think the 2 informations are transversal, and that's why I would > >> prefer 2 flags. Also, having 2 separate flags would also help to keep > >> backward compatibility with previous versions. > > > > Hmm, not sure how we will break compatibility in that case? > > If we'll make TX_IP_CKSUM to be 1 bit value (1 << X) then for current > > drivers nothing should change, no? > > Yes, you're right, sorry.
Actually, you right - squeezing these 3 flags into 2 bits would break backward compatibility. Sorry, didn't think properly. Konstantin > > Olivier