On 5/11/2018 4:36 PM, Iremonger, Bernard wrote: >> -----Original Message----- >> From: dev [mailto:[email protected]] On Behalf Of Shahaf Shuler >> Sent: Thursday, May 10, 2018 5:39 AM >> To: Yigit, Ferruh <[email protected]>; Lu, Wenzhuo >> <[email protected]>; Wu, Jingjing <[email protected]> >> Cc: [email protected]; Dai, Wei <[email protected]>; Zhang, Qi Z >> <[email protected]> >> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload >> supported >> >> Thursday, May 10, 2018 1:09 AM, Ferruh Yigit: >>> Subject: [PATCH] app/testpmd: check if CRC strip offload supported >>> >>> Testpmd set CRC_STRIP offload blindly, this is wrong according offload >>> API definition, and will cause error for the PMDs that doesn't support >>> CRC_STRIP like virtual PMDs. >>> >>> Check if underlying device report this capability and don't set it if >>> not supported. >>> >>> Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API") >>> Cc: [email protected] >>> >>> Signed-off-by: Ferruh Yigit <[email protected]> >> >> Yes this is the correct behavior. I hope all the PMDs report the CRC strip >> correctly. >> >> Acked-by: Shahaf Shuler < [email protected]> > > Acked-by: Bernard Iremonger <[email protected]>
Applied to dpdk-next-net/master, thanks.
