On Mon, May 14, 2018 at 01:09:32PM +0800, Andy Green wrote:
> Signed-off-by: Andy Green <a...@warmcat.com>
> ---
>  lib/librte_eal/common/eal_common_string_fns.c  |   34 
> ++++++++++++++++++++++++
>  lib/librte_eal/common/include/rte_string_fns.h |    7 +----
>  2 files changed, 36 insertions(+), 5 deletions(-)

While I'm aware this was suggested by other reviewers, I really don't feel
that it is necessary to actually import the code. If libbsd is present on
the system, we will use it directly. If libbsd is not present, the snprintf
provides an acceptable fallback for strlcpy IMHO. Having the full function
without good justification seems excessive.


Reply via email to