On 05/17/2018 06:36 PM, Bruce Richardson wrote:
On Mon, May 14, 2018 at 01:09:32PM +0800, Andy Green wrote:
Signed-off-by: Andy Green <a...@warmcat.com>
  lib/librte_eal/common/eal_common_string_fns.c  |   34 ++++++++++++++++++++++++
  lib/librte_eal/common/include/rte_string_fns.h |    7 +----
  2 files changed, 36 insertions(+), 5 deletions(-)

While I'm aware this was suggested by other reviewers, I really don't feel
that it is necessary to actually import the code. If libbsd is present on
the system, we will use it directly. If libbsd is not present, the snprintf
provides an acceptable fallback for strlcpy IMHO. Having the full function
without good justification seems excessive.

Well, as you can probably guess, I don't really mind either way.

This also implies another patch to export rte_strlcpy since it's no longer an inline in the headers this way.

I removed these patches and rebuilt dpdk and then lagopus without it with the idea of pasting the compile error. But I can't reproduce the original problem... since then I rebased on current master dpdk, got updated to gcc 8.1 and added more patches on lagopus.

So just drop this patch if you don't want the bsd lstrcpy.



Reply via email to