On Tue, May 22, 2018 at 02:01:38PM +0100, Ferruh Yigit wrote: > On 5/22/2018 12:26 PM, Adrien Mazarguil wrote: > > As reported by ICC, an array initializer that uses values found in the > > array being initialized, although semantically correct (GCC and clang do > > not complain and generate correct code), results in undefined behavior > > since initialization order is itself undefined. > > > > This patch restores the static keyword and initializes array entries with > > constant expressions as a safety measure. > > > > Fixes: f76ccd763422 ("net/mlx4: refactor RSS conversion functions") > > > > Reported-by: Ferruh Yigit <ferruh.yi...@intel.com> > > Signed-off-by: Adrien Mazarguil <adrien.mazarg...@6wind.com> > > > > -- > > > > Shahaf, Ferruh, please remove the "Note the loss of the [...]" paragraph of > > the original commit if this patch gets squashed in it, as it is no longer > > relevant in that case. > > Squashed into relevant commit in next-net, thanks. > > Can you please confirm updated commit log?
Looks good, thanks! -- Adrien Mazarguil 6WIND