Hi Ferruh, I have checked the patch done. I am ok with the same.
Thanks Vipin Varghese > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, May 23, 2018 1:41 PM > To: Wiles, Keith <keith.wi...@intel.com>; Varghese, Vipin > <vipin.vargh...@intel.com> > Cc: DPDK <dev@dpdk.org>; ophi...@mellanox.com; tho...@monjalon.net; > ol...@mellanox.com > Subject: Re: [PATCH v4] net/tap: perform proto field update for tun only > > On 5/23/2018 5:48 AM, Wiles, Keith wrote: > > > > > >> On May 22, 2018, at 11:44 PM, Varghese, Vipin <vipin.vargh...@intel.com> > wrote: > >> > >> The TX function is shared between TAP and TUN PMD. Checking TUN-TAP > >> type field will ensure the TAP PMD will always have protocol field as > >> 0. > >> > >> Signed-off-by: Vipin Varghese <vipin.vargh...@intel.com> > >> Suggested-by: Ferruh Yigit <ferruh.yi...@intel.com> > >> --- > >> Changes in V4: > >> - convert comparision with MACRO - Keith Wiles > >> - add LOG err for tun using set MAC - Ophir Munk > >> > >> Changes in V3: > >> - remove type field from rx struct - Ophir Munk > >> - add space for comment in struct - Ophir Munk > >> - pass type field into eth_dev_tap_create - Ophir Munk > >> - replace with enum value for type - Ophir Munk > >> - return as 'not supported' for mac_set - Vipin Varghese > >> > >> Changes in V2: > >> - updated in comment wording - Keith Wiles > >> - remove debug print from tx code - Keith Wiles — > > > > Looks good to me. > > > > Acked-by: Keith Wiles<keith.wi...@intel.com> > > I re-did a v5 for this patch yesterday and it has already been merged into > rc5. > https://dpdk.org/dev/patchwork/patch/40352/ > > @vipin, can you please check if the merged patch is good, and if is there any > diff > with what you have sent here? > > Thanks, > ferruh > > > > > Regards, > > Keith > >
