On 06/07/2018 06:51 AM, Tiwei Bie wrote:
On Wed, Jun 06, 2018 at 02:31:28PM +0200, Maxime Coquelin wrote:
Instead of checking the multiple Virtio features bits for
every packet, let's do the check once at configure time and
store it in virtio_hw struct.
Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
---
[...]
@@ -270,8 +261,7 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct
rte_mbuf *cookie,
* which is wrong. Below subtract restores correct pkt size.
*/
cookie->pkt_len -= head_size;
- /* if offload disabled, it is not zeroed below, do it now */
I think there is no need to remove this comment.
Oh right, that was not intentional.
Will add it again.
Apart from that,
Reviewed-by: Tiwei Bie <tiwei....@intel.com>
Thanks,
Maxime
- if (offload == 0) {
+ if (!vq->hw->has_tx_offload) {
ASSIGN_UNLESS_EQUAL(hdr->csum_start, 0);
ASSIGN_UNLESS_EQUAL(hdr->csum_offset, 0);
ASSIGN_UNLESS_EQUAL(hdr->flags, 0);
[...]
