-----Original Message----- > Date: Thu, 4 Oct 2018 13:45:42 +0000 > From: "Iremonger, Bernard" <bernard.iremon...@intel.com> > To: Jerin Jacob <jerin.ja...@caviumnetworks.com>, "Lu, Wenzhuo" > <wenzhuo...@intel.com>, "Wu, Jingjing" <jingjing...@intel.com> > CC: "dev@dpdk.org" <dev@dpdk.org>, "shah...@mellanox.com" > <shah...@mellanox.com> > Subject: RE: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 > checksum for csum engine > > Hi Jerin,
Hi Iremonger, > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Wednesday, October 3, 2018 7:17 PM > > To: Lu, Wenzhuo <wenzhuo...@intel.com>; Wu, Jingjing > > <jingjing...@intel.com>; Iremonger, Bernard > > <bernard.iremon...@intel.com> > > Cc: dev@dpdk.org; shah...@mellanox.com; Jerin Jacob > > <jerin.ja...@caviumnetworks.com> > > Subject: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 > > checksum for csum engine > > > > Collect and prints the statistics for PKT_RX_EL4_CKSUM_BAD errors. > > > > Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > Reviewed-by: Andrew Rybchenko <arybche...@solarflare.com> > > --- > > <snip> > > The following checkpatch warnings should probably be fixed > > WARNING:LONG_LINE: line over 80 characters > #86: FILE: app/test-pmd/testpmd.c:1043: > + printf(" Bad-ipcsum: %-14"PRIu64" Bad-l4csum: > %-14"PRIu64"Bad-outer-l4csum: %-14"PRIu64"\n", > > WARNING:LONG_LINE: line over 80 characters > #98: FILE: app/test-pmd/testpmd.c:1063: > + printf(" Bad-ipcsum:%14"PRIu64" > Bad-l4csum:%14"PRIu64" Bad-outer-l4csum: %-14"PRIu64"\n", > AFAIK, printf's string can be >80 to allow string strip
