Re: [dpdk-dev] [PATCH v2 14/20] net/ice: support statistics

[Varghese, Vipin]

Snipped
> >
> > snipped
> > > + ns->eth.tx_bytes -= (ns->eth.tx_unicast + ns->eth.tx_multicast +
> > > +                      ns->eth.tx_broadcast) * ETHER_CRC_LEN;
> >
> > In earlier patch for 'mtu set check' we added VSI SWITCH VLAN. Should
> > we add VSI VLAN here?
> Don't need. They're different functions. We add crc length here because of HW
> counts the packet length before crc is added.
So you are not fetching stats from HW registers from switch is this correct? 
How will you get stats for actually transmitted in xstats? As I understand 
xstats is for switch HW stats right?
> 
> 
> > snipped