On 01/15, Stephen Hemminger wrote:
>On Wed, 16 Jan 2019 08:34:52 +0800
>Xiaolong Ye <xiaolong...@intel.com> wrote:
>
>> The comment for igbuio_pci_irqhandler is out of date as the code evolves,
>> remove it to avoid misleading.
>>
>> Signed-off-by: Xiaolong Ye <xiaolong...@intel.com>
>> ---
>> kernel/linux/igb_uio/igb_uio.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c
>> index 3cf394bdf..d6ac51e79 100644
>> --- a/kernel/linux/igb_uio/igb_uio.c
>> +++ b/kernel/linux/igb_uio/igb_uio.c
>> @@ -185,10 +185,6 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32
>> irq_state)
>> return 0;
>> }
>>
>> -/**
>> - * This is interrupt handler which will check if the interrupt is for the
>> right device.
>> - * If yes, disable it here and will be enable later.
>> - */
>> static irqreturn_t
>> igbuio_pci_irqhandler(int irq, void *dev_id)
>> {
>
>The comment is partially correct; if you look at the legacy case.
>
>Maybe better to move the comment to pci_check_and_mask_intx in compat.h?
>I see there is another incorrect comment there.
>
Hmm, you're right, this comment is correct for the legacy case, I'll move the
comment to pci_check_and_mask_intx as you suggested.
Thanks,
Xiaolong
