17/01/2019 18:23, Ferruh Yigit: > On 1/17/2019 5:17 PM, Harry van Haaren wrote: > > This commit reworks the checks for binutils 2.30 and how > > the flags to disable AVX512F are passed to the compiler. > > > > Previously the #define for including AVX512 code was set, > > while the -mno-avx512f argument was given to the compiler. > > This would cause gcc to correctly refuse to emit AVX512 > > instructions, but the rte_memcpy code that includes AVX512 > > optimizations was being added to the build. > > > > The check for binutils check is now moved to x86 as it is > > irrelevant for other architectures, and the -mno-avx512f > > flag is passed to a march_opts array in meson. As the > > -mno-avx512 flag is added earlier in the build, the code > > in rte_memcpy is no longer attempted to be compiled. > > > > This commit also adds a message print in the meson configure > > stage to alert the user of the workaround being employed. > > > > Fixes: a32ca9a4ebc1 ("mk: fix scope of disabling AVX512F support") > > > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > > Tested-by: Ferruh Yigit <ferruh.yi...@intel.com> > > Thanks for the fix Harry.
Applied (with message reworded as suggested), thanks