Re: [dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture

[Pattan, Reshma]

> -----Original Message-----
> From: Varghese, Vipin
> 
> @@ -152,7 +157,7 @@ pdump_usage(const char *prgname)
>                       "[ring-size=<ring size>default:16384],"
>                       "[mbuf-size=<mbuf data size>default:2176],"
>                       "[total-num-mbufs=<number of
> mbufs>default:65535]'\n",
> -                     prgname);
> +                     prgname, CMD_LINE_OPT_MULTI,

IMO, simple  short options can be used instead of long, as this option don't 
have any arguments to pass.

> 
> +static int
> +dump_packets_core(void *arg)
> +{
> +     struct pdump_tuples *pt = (struct pdump_tuples *) arg;
> +
> +     printf(" core (%u); port %u device (%s) queue %u\n",
> +                     rte_lcore_id(), pt->port, pt->device_id, pt->queue);

Log message can be improved to be "  packet_dump for port <num> running on core 
<id>"

> +     fflush(stdout);

Why is fflush used here and  in below other places?

> 
> +The ``--multi`` command line option is optional argument. If passed,
> +capture will be running on unqiue cores for all ``--pdump`` options. If

Typo unique

Thanks,
Reshma