Hi Reshma, snipped > Nit picks: > > > > > +The ``--multi`` command line option is optional argument. If passed, > > +capture will be running on unique cores for all ``--pdump`` options. > > +If ignored, capture will be running on single core for all ``--pdump`` > > options. > > + > > Instead of just saying on single cores or on unique cores, worth mentioning > uses > the 1st core of eal coremask/corelist for single case. I have humbly disagree with this point, since the value of 1st core varies with isol, taskset, and eal option '--master'.
> For multi case uses the cores except the 1st in one in coremask? Same as above. > > > The ``--pdump`` command line option is mandatory and it takes various > > sub arguments which are described in below section. > > > > + $ sudo ./build/app/dpdk-pdump -l 3,4,5 -- --multi --pdump > > 'port=0,queue=*,rx-dev=/tmp/rx-1.pcap' --pdump 'port=1,queue=*,rx- > > dev=/tmp/rx-2.pcap' > > -- > > 2.17.1 > > In the command if you pass anything --m/--mul/--mult/multi the command still > succeeds.. Did you check the reason for that? Yes it passes, during unit test checked too. But I do not understand if it is problem. > > Thanks, > Reshma
