On 6/24/2019 8:53 AM, Andrew Rybchenko wrote: > Hi Thomas, > > On 6/24/19 1:37 AM, Thomas Monjalon wrote: >> 18/06/2019 09:52, Ferruh Yigit: >>> On 6/10/2019 8:38 AM, Andrew Rybchenko wrote: >>>> checkpatches.sh generates warnings/errors because of a bit different >>>> coding style in base driver. >> [...] >>> Series applied to dpdk-next-net/master, thanks. >>> >>> Fixed following checkpatch warnings while merging: >> There are a lot more checkpatch warnings in this code. >> Is it possible to fix the style of the code in the sfc/base directory? >> Or we prefer to continue with so many checkpatch warnings? > > In short: I'm trying to minimize a number of warnings, but it is not always > possible. I'll pay even more attention to it in the future.
There are a few known syntax differences between DPDK and sfc/base/*, most of the warnings are from those, at least I am OK with them as long as the syntax is consistent in sfc/base/* which seems the case, I believe this is better than having a mixture of two different syntax in the code.
