On Thu, Oct 24, 2019 at 5:37 PM Stephen Hemminger <step...@networkplumber.org> wrote: > > > > rte_logs could be hidden, but I am not that confortable about > > > > doing it right away: I added an accessor to rte_logs.file, but I am fine > > > > with dropping the last patch and wait for actually hiding this in the > > > > next > > > > ABI break. > > > > > > 19.11 is an api/abi break so maybe do it now. > > > > I went and hid more internals, I did not see an impact on really basic > > bench. > > > > I would appreciate other opinions. > > These all look good. There is probably a lot more that could be > done, adding more accessors in 20.02 could help but more hiding won't happen > again until 20.11
Yes, I went with the low hanging fruits. It is a long term effort in any case, when reviewing too. -- David Marchand
