On Tue, Jul 28, 2020 at 10:39 AM Ferruh Yigit <[email protected]> wrote:
> On 7/28/2020 6:33 PM, Ajit Khaparde wrote: > > > > > > On Tue, Jul 28, 2020 at 10:00 AM Ferruh Yigit <[email protected] > > <mailto:[email protected]>> wrote: > > > > On 7/28/2020 7:34 AM, Ajit Khaparde wrote: > > > From: Mike Baucom <[email protected] > > <mailto:[email protected]>> > > > > > > Moved setting the refcnt for shadow tcam and table entries to the > > > allocation path only. The insert can be called multiple times for > > > updates and was resetting the refcnt to 1 each time. Now multiple > > > insertion/modifications will not change the reference count. > > > > > > Fixes: 3cf8fb975df9 ("net/bnxt: add shadow and search capability > to tcam") > > > > > > Signed-off-by: Mike Baucom <[email protected] > > <mailto:[email protected]>> > > > Reviewed-by: Kishore Padmanabha <[email protected] > > <mailto:[email protected]>> > > > > The fix patch already in this set, why not fix the issue at first > place where it > > is introduced? > > > > This patch distributed to 1/22 & 12/22 while merging, please confirm. > > > > Ferruh, > > I took a quick look at the patches and I think we may be able to merge > them. > > But I have not squashed and compiled the patches yet. So I can't tell if > merging > > them > > will break the build. > > I have verified the patch by patch build, which looks good and pushed to > next-net. > Also verified that final code is same, but better to have another eye to > double > check. > Thanks Ferruh. I am checking the code now.
