On Tue, Nov 24, 2020 at 4:15 PM Timothy Redaelli <tredae...@redhat.com> wrote:
>
> Commit 06c7871dde01 ("eal: restrict default plugin path to shared lib mode")
> introduced a check that enabled shared lib mode when librte_eal.so can
> be loaded, but it can't work, at least, on Fedora/CentOS/RHEL since .so
> symlinks are not installed when you install dpdk package, but only when
> you install dpdk-devel package.
>
> This commit uses librte_eal.so.ABI_VERSION to check for shared lib,
> since it exists on any linux distributions.
>
> See Fedora Packaging Guidelines for more informations:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
>
> Fixes: 06c7871dde01 ("eal: restrict default plugin path to shared lib mode")
> Cc: bruce.richard...@intel.com
> Cc: sta...@dpdk.org
> Signed-off-by: Timothy Redaelli <tredae...@redhat.com>Same comment as Bruce on the != NULL location, but otherwise lgtm. Acked-by: David Marchand <david.march...@redhat.com> -- David Marchand
