On Tue, Oct 19, 2021 at 9:09 PM Aaron Conole <acon...@redhat.com> wrote: > > David Marchand <david.march...@redhat.com> writes: > > > Cores count has a direct impact on the time needed to complete unit > > tests. > > > > Currently, the core list used for unit test is enforced to "all cores on > > the system" with no way for (CI) users to adapt it. > > On the other hand, EAL default behavior (when no -c/-l option gets passed) > > is to start threads on as many cores available in the process cpu > > affinity. > > > > Remove logic from meson: users can then select where to run the tests by > > either running meson with a custom cpu affinity (using taskset/cpuset > > depending on OS) or by passing a --test-args option to meson. > > > > Example: > > $ sudo meson test -C build --suite fast-tests -t 3 --test-args "-l 0-3" > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > --- > > LGTM - the spelling issue flagged seems to be a false positive.
The first spelling issue is fixed in main: https://git.dpdk.org/dpdk/commit/?id=d0db11a82609 The other three warnings (all of them about "test-args") are introduced by this patch, and this is a problem: once merged, I understand any following patch will get flagged as failing this check. There may be something better to do for the mid/long term, but the quicker is to add test-args to UNH dictionnary. Once done, I can merge this patch. Lincoln, Brandon? > > Acked-by: Aaron Conole <acon...@redhat.com> > Thanks for the review. -- David Marchand
