09/03/2022 12:50, Dariusz Sosnowski: > From: Ferruh Yigit <[email protected]> > > On 3/1/2022 11:51 AM, Dariusz Sosnowski wrote: > > > This patch adds implicit registration of metadata dynamic field and > > > flag > > > > Hi Dariusz, > > > > metaday dynamic field is explicitly registered when testpmd command used > > to enable tx metadata, or rte flow rule created with "set_meta" action. > > > > Can you please document more when this implicit enablement is required? > > And why that case doesn't cover above explicit enable cases? > > Before this patch, when a user inserted a flow rule with MODIFY_FIELD action, > which modified packet metadata, the metadata dynamic field was not > registered, as opposed to > what happened with SET_META action. Goal of this patch is to make the > behavior consistent > between these two actions.
I think consistency should be ensured by the PMD. Why not registering the field in the PMD?
