On Fri, 1 Jul 2022 18:50:34 +0200 Morten Brørup <m...@smartsharesystems.com> wrote:
> But I guess it is something else. > > Anyway, this function has ugly alignment problems (also before the patch), > and has gone through a couple of iterations to silence warnings from the > compiler. These warnings should have been addressed instead of silenced. > Mattias has suggested a far better solution [2] than mine, which also > correctly addresses the compiler alignment warnings, so we will probably end > up with his solution instead. > > [2] > http://inbox.dpdk.org/dev/am8pr07mb7666ad7bf7b780cc5062c14598...@am8pr07mb7666.eurprd07.prod.outlook.com/T/#m1a76490541fce4a85b12d9390f2f4fac5a9f4660 > Maybe some mix of the memcpy for unaligned and odd length and faster (unrolled?) version for the case of aligned and exact multiple? Or just take code from FreeBSD?
