On 11/22/2022 3:30 PM, ok...@kernel.org wrote: > From: Sinan Kaya <ok...@kernel.org> > > rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get > is not checked, potentially leaving dev_info uninitialized. > > Signed-off-by: Sinan Kaya <ok...@kernel.org> > --- > lib/ethdev/rte_class_eth.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/ethdev/rte_class_eth.c b/lib/ethdev/rte_class_eth.c > index 838b3a8f9f..8165e5adc0 100644 > --- a/lib/ethdev/rte_class_eth.c > +++ b/lib/ethdev/rte_class_eth.c > @@ -51,7 +51,9 @@ eth_mac_cmp(const char *key __rte_unused, > return -1; /* invalid devargs value */ > > /* Return 0 if devargs MAC is matching one of the device MACs. */ > - rte_eth_dev_info_get(data->port_id, &dev_info); > + if (rte_eth_dev_info_get(data->port_id, &dev_info) < 0) > + return -1; > + > for (index = 0; index < dev_info.max_mac_addrs; index++) > if (rte_is_same_ether_addr(&mac, &data->mac_addrs[index])) > return 0;
Minor issue, but before patch, comment about MAC address match applies to block of code that gets dev_info and does MAC compare. After patch, get dev_info is separate code block and comment doesn't really apply to that block, although it is possible to understand what comment is referring, still I think better to move it down to the block that does MAC compare.
