20/02/2023 16:07, Morten Brørup: > With the new viewing angle, the current define RTE_IOVA_AS_PA makes more > sense to me now than before. So we should probably stick with it, rather than > introduce something that might confuse developers who already have the same > viewing angle. > > But it still seems counterintuitive to me that disabling some feature > ("enable_iova_as_pa") is not supported throughout DPDK; the logic seems > inverted. Apparently, it also makes it difficult to assign good titles to > patches that support disabling such a feature. :-) > > <irony> > On the positive side, since everything supports this "enable_iova_as_pa" > feature, we don't need to add it to the PMD feature list. If the logic wasn't > inverted like this, the PMD feature list should probably reflect which PMDs > supported the "iova_as_va_only" compile time option. ;-) > </irony>
That's a change I would like to do: The Meson variable in the drivers should be "support_iova_as_va" and would mean we can compile the driver when "enable_iova_as_pa" is false.