All messages that because of an error should be at log level
NOTICE or above. Do not break log messages across lines.
Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
Acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>
---
lib/latencystats/rte_latencystats.c | 30 ++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/lib/latencystats/rte_latencystats.c
b/lib/latencystats/rte_latencystats.c
index 6ef8e344bf..8aff96a449 100644
--- a/lib/latencystats/rte_latencystats.c
+++ b/lib/latencystats/rte_latencystats.c
@@ -243,7 +243,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,
latency_stats_index = rte_metrics_reg_names(ptr_strings,
NUM_LATENCY_STATS);
if (latency_stats_index < 0) {
- LATENCY_STATS_LOG(DEBUG,
+ LATENCY_STATS_LOG(ERR,
"Failed to register latency stats names");
return -1;
}
@@ -263,7 +263,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,
ret = rte_eth_dev_info_get(pid, &dev_info);
if (ret != 0) {
- LATENCY_STATS_LOG(INFO,
+ LATENCY_STATS_LOG(NOTICE,
"Error during getting device (port %u) info:
%s",
pid, strerror(-ret));
@@ -275,18 +275,18 @@ rte_latencystats_init(uint64_t app_samp_intvl,
cbs->cb = rte_eth_add_first_rx_callback(pid, qid,
add_time_stamps, user_cb);
if (!cbs->cb)
- LATENCY_STATS_LOG(INFO, "Failed to "
- "register Rx callback for pid=%d, "
- "qid=%d", pid, qid);
+ LATENCY_STATS_LOG(NOTICE,
+ "Failed to register Rx callback for
pid=%u, qid=%u",
+ pid, qid);
}
for (qid = 0; qid < dev_info.nb_tx_queues; qid++) {
cbs = &tx_cbs[pid][qid];
cbs->cb = rte_eth_add_tx_callback(pid, qid,
calc_latency, user_cb);
if (!cbs->cb)
- LATENCY_STATS_LOG(INFO, "Failed to "
- "register Tx callback for pid=%d, "
- "qid=%d", pid, qid);
+ LATENCY_STATS_LOG(NOTICE,
+ "Failed to register Tx callback for
pid=%u, qid=%u",
+ pid, qid);
}
}
return 0;
@@ -307,7 +307,7 @@ rte_latencystats_uninit(void)
ret = rte_eth_dev_info_get(pid, &dev_info);
if (ret != 0) {
- LATENCY_STATS_LOG(INFO,
+ LATENCY_STATS_LOG(NOTICE,
"Error during getting device (port %u) info:
%s",
pid, strerror(-ret));
@@ -318,17 +318,17 @@ rte_latencystats_uninit(void)
cbs = &rx_cbs[pid][qid];
ret = rte_eth_remove_rx_callback(pid, qid, cbs->cb);
if (ret)
- LATENCY_STATS_LOG(INFO, "failed to "
- "remove Rx callback for pid=%d, "
- "qid=%d", pid, qid);
+ LATENCY_STATS_LOG(NOTICE,
+ "Failed to remove Rx callback for
pid=%u, qid=%u",
+ pid, qid);
}
for (qid = 0; qid < dev_info.nb_tx_queues; qid++) {
cbs = &tx_cbs[pid][qid];
ret = rte_eth_remove_tx_callback(pid, qid, cbs->cb);
if (ret)
- LATENCY_STATS_LOG(INFO, "failed to "
- "remove Tx callback for pid=%d, "
- "qid=%d", pid, qid);
+ LATENCY_STATS_LOG(NOTICE,
+ "Failed to remove Tx callback for
pid=%u, qid=%u",
+ pid, qid);
}
}
--
2.43.0
