Hi, > -----Original Message----- > From: Bing Zhao <[email protected]> > Sent: Wednesday, July 3, 2024 10:00 > To: Mahmoud Maatuq <[email protected]>; Dariusz > Sosnowski <[email protected]>; Slava Ovsiienko > <[email protected]>; Ori Kam <[email protected]>; Suanming Mou > <[email protected]>; Matan Azrad <[email protected]>; Maayan > Kashani <[email protected]> > Cc: [email protected] > Subject: RE: [PATCH v3] net/mlx5: fix matcher object memory leak > > Hi, > > > > -----Original Message----- > > From: Mahmoud Maatuq <[email protected]> > > Sent: Wednesday, July 3, 2024 4:15 AM > > To: Dariusz Sosnowski <[email protected]>; Slava Ovsiienko > > <[email protected]>; Bing Zhao <[email protected]>; Ori Kam > > <[email protected]>; Suanming Mou <[email protected]>; Matan > Azrad > > <[email protected]>; Maayan Kashani <[email protected]> > > Cc: [email protected]; Mahmoud Maatuq <[email protected]> > > Subject: [PATCH v3] net/mlx5: fix matcher object memory leak > > > > External email: Use caution opening links or attachments > > > > > > This makes sure that the allocated matcher object is freed for all > > branches that return NULL. > > > > Coverity issue: 426424 > > Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable > > reconfigure") > > Cc: [email protected] > > > > Signed-off-by: Mahmoud Maatuq <[email protected]> > > --- > > v3: > > * changed commit message. > > * fixed typos > > v2: > > * fixed Fixes and Cc tags. > > --- > > drivers/net/mlx5/mlx5_flow_dv.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > > b/drivers/net/mlx5/mlx5_flow_dv.c index d46beffd4c..8a0d58cb05 100644 > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > @@ -12010,9 +12010,12 @@ flow_matcher_create_cb(void *tool_ctx, void > > *cb_ctx) > > items = *((const struct rte_flow_item **)(ctx->data2)); > > resource->matcher_object = mlx5dr_bwc_matcher_create > > (resource->group->tbl, > > resource->priority, items); > > - if (!(resource->matcher_object)) > > + if (!resource->matcher_object) { > > + mlx5_free(resource); > > return NULL; > > + } > > #else > > + mlx5_free(resource); > > return NULL; > > #endif > > } > > -- > > 2.43.0 > > Acked-by: Bing Zhao <[email protected]>
Thank you for all the changes and the patch! Acked-by: Dariusz Sosnowski <[email protected]> Best regards, Dariusz Sosnowski
