> Some cryptodev functions were not included in the extern "C" block,
> so it is moved to start before.
>
> An include is also moved to avoid being part of this block.
>
> Fixes: 719834a6849e ("use C linkage where appropriate in headers")
> Cc: [email protected]
>
> Reported-by: Zhigang Hu <[email protected]>
> Signed-off-by: Thomas Monjalon <[email protected]>
> ---
> .mailmap | 1 +
> lib/cryptodev/rte_cryptodev.h | 10 +++++-----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/.mailmap b/.mailmap
> index 2bf38f9e8c..1e4bb06d6e 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -1794,6 +1794,7 @@ Zhenghua Zhou <[email protected]>
> Zhenning Xiao <[email protected]>
> Zhe Tao <[email protected]>
> Zhichao Zeng <[email protected]>
> +Zhigang Hu <[email protected]>
> Zhigang Lu <[email protected]>
> Zhiguang He <[email protected]>
> Zhihong Peng <[email protected]>
> diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h
> index c64d2f83a0..31a7edb189 100644
> --- a/lib/cryptodev/rte_cryptodev.h
> +++ b/lib/cryptodev/rte_cryptodev.h
> @@ -21,6 +21,11 @@
> #include <rte_rcu_qsbr.h>
>
> #include "rte_cryptodev_trace_fp.h"
> +#include "rte_cryptodev_core.h"
Fix is ok but rte_cryptodev_core.h should not be moved up.
It is added in the middle to segregate the fast path APIs.
And it is an internal header which cannot be included by app directly.
I think the same schema is followed in ethdev as well.
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
>
> /**
> * @internal Logtype used for cryptodev related messages.
> @@ -1928,11 +1933,6 @@ int rte_cryptodev_remove_deq_callback(uint8_t
> dev_id,
> uint16_t qp_id,
> struct rte_cryptodev_cb *cb);
>
> -#include <rte_cryptodev_core.h>
> -
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> /**
> *
> * Dequeue a burst of processed crypto operations from a queue on the crypto
> --
> 2.47.1
