Hi, > -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Thursday, February 20, 2025 10:32 AM > To: dev@dpdk.org > Cc: Stephen Hemminger <step...@networkplumber.org>; Xu, Rosen > <rosen...@intel.com> > Subject: [PATCH v2 05/14] net/ipn3ke: remove unnecessary dereference > > Since it is a function pointer, the expression *hw->f_mac_read and > hw->f_mac_read are equivalent in C. > > Remove excession indentation here. > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > --- > drivers/net/intel/ipn3ke/ipn3ke_ethdev.c | 27 +++++------------------- > 1 file changed, 5 insertions(+), 22 deletions(-) > > diff --git a/drivers/net/intel/ipn3ke/ipn3ke_ethdev.c > b/drivers/net/intel/ipn3ke/ipn3ke_ethdev.c > index baae80d661..c8f06a06cb 100644 > --- a/drivers/net/intel/ipn3ke/ipn3ke_ethdev.c > +++ b/drivers/net/intel/ipn3ke/ipn3ke_ethdev.c > @@ -229,34 +229,17 @@ ipn3ke_mtu_set(struct ipn3ke_hw *hw, uint32_t > mac_num, > uint32_t rx; > uint32_t tmp; > > - if (!(*hw->f_mac_read) || !(*hw->f_mac_write)) > + if (!hw->f_mac_read || !hw->f_mac_write) > return; > > - (*hw->f_mac_read)(hw, > - &tx, > - txaddr, > - mac_num, > - eth_group_sel); > + hw->f_mac_read(hw, &tx, txaddr, mac_num, eth_group_sel); > > - (*hw->f_mac_read)(hw, > - &rx, > - rxaddr, > - mac_num, > - eth_group_sel); > + hw->f_mac_read(hw, &rx, rxaddr, mac_num, eth_group_sel); > > tmp = ipn3ke_mtu_cal(tx, rx); > > - (*hw->f_mac_write)(hw, > - tmp, > - txaddr, > - mac_num, > - eth_group_sel); > - > - (*hw->f_mac_write)(hw, > - tmp, > - rxaddr, > - mac_num, > - eth_group_sel); > + hw->f_mac_write(hw, tmp, txaddr, mac_num, eth_group_sel); > + hw->f_mac_write(hw, tmp, rxaddr, mac_num, eth_group_sel); > } > > static void > -- > 2.47.2
Reviewed-by: Rosen Xu <rosen...@intel.com>
