Previously, `capture_name` defaulted to a "dynamic" value.
This caused non-deterministic documentation and could lead
to overwriting capture files if the method was called
multiple times within a single Python process.
Bugzilla ID: 1718
Signed-off-by: Clemens Famulla-Conrad <cfamullacon...@suse.com>
---
.mailmap | 1 +
.../traffic_generator/capturing_traffic_generator.py | 5 ++++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.mailmap
index 76f65e5114..cd5362f130 100644
--- a/.mailmap
+++ b/.mailmap
@@ -272,6 +272,7 @@ Cian Ferriter <cian.ferri...@intel.com>
Ciara Loftus <ciara.lof...@intel.com>
Ciara Power <ciara.po...@intel.com>
Claire Murphy <claire.k.mur...@intel.com>
+Clemens Famulla-Conrad <cfamullacon...@suse.com>
Cody Doucette <douce...@bu.edu>
Congwen Zhang <zhang.cong...@zte.com.cn>
Conor Fogarty <conor.foga...@intel.com>
diff --git
a/dts/framework/testbed_model/traffic_generator/capturing_traffic_generator.py
b/dts/framework/testbed_model/traffic_generator/capturing_traffic_generator.py
index 66a77da9c4..c1e4a898d4 100644
---
a/dts/framework/testbed_model/traffic_generator/capturing_traffic_generator.py
+++
b/dts/framework/testbed_model/traffic_generator/capturing_traffic_generator.py
@@ -70,7 +70,7 @@ def send_packets_and_capture(
receive_port: Port,
filter_config: PacketFilteringConfig,
duration: float,
- capture_name: str = _get_default_capture_name(),
+ capture_name: str = None,
) -> list[Packet]:
"""Send `packets` and capture received traffic.
@@ -104,6 +104,9 @@ def send_packets_and_capture(
duration,
)
+ if capture_name is None:
+ capture_name = _get_default_capture_name()
+
self._logger.debug(f"Received packets:
{get_packet_summaries(received_packets)}")
self._write_capture_from_packets(capture_name, received_packets)
return received_packets
--
2.43.0
