On Mon, Jun 16, 2025 at 11:49:03AM +0200, Tomasz Duszynski wrote: > >16/06/2025 08:53, Tomasz Duszynski: > >> @@ -86,6 +86,7 @@ always_enable = [ > >> 'ring', > >> 'stack', > >> 'telemetry', > >> + 'pmu', > >> ] > > > >This list is alphabetically sorted. > > Right, missed that. > > > > >What is the justification for always enabling PMU lib? > >Is it a good idea to always enable an experimental library? > > Well, since on Linux eal depends on pmu, disabling pmu ends up disabling > eal, which breaks minimal build. > > As for the second question - no. I think ideally lib should remain > optional. However, since trace is part of eal, that indirectly forces > pmu to be built. >
Or else you need to put ifdefs into the EAL code to only call the pmu functions when the library is enabled. Given that PMU library is only enabled for Linux, and yet there are changes in this patch to a number of common EAL files, that is probably a good option to take. It gives you the ability to make PMU optional, as well as supporting non-linux OS's. /Bruce
