> diff --git a/lib/meson.build b/lib/meson.build > index 1934cb4a29..87b567f01b 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -13,7 +13,7 @@ libraries = [ > 'kvargs', # eal depends on kvargs > 'argparse', > 'telemetry', # basic info querying > - 'pmu', > + 'pmu', # trace depends on pmu > 'eal', # everything depends on eal > 'ptr_compress', > 'ring',
@Tomasz, Please re-read my v1 review feedback [1]: The PMU library should depend on the EAL, not the other way around! How else is the PMU library supposed to use EAL functions like rte_mem_page_size()? @Jerin or @Bruce, do any of you have some suggestions for how to achieve the proper dependency chain here? Worst case, we will have to move PMU into EAL. :-( [1]: https://inbox.dpdk.org/dev/98cbd80474fa8b44bf855df32c47dc35e9f...@smartserver.smartshare.dk/T/#u Besides that, good stuff. :-)
