28/07/2025 07:11, Pavan Nikhilesh Bhagavatula: > >Acked-by: Chengwen Feng <fengcheng...@huawei.com> > > > > Thomas, > > Now that Feng Chengwen is ok with this change, can this be merged > along with the ABI breaking changes in 25.11? > Given that techboard approves the change. > This change helps reduce ABI breakage when a new feature is added.
I would be in favor of this change. Let's request a vote in the next techboard meeting. (Cc techbo...@dpdk.org and added in the meeting agenda) > >On 2025/7/25 14:04, Pavan Nikhilesh Bhagavatula wrote: > >>>> Deprecate rte_dma_conf structure to allow for a more flexible > >>>> configuration of DMA devices. > >>>> The new structure will have a flags field instead of multiple > >>>> boolean fields for each feature. > >>>> > >>>> Signed-off-by: Pavan Nikhilesh <mailto:pbhagavat...@marvell.com> > >>>> --- > >>>> +* dmadev: The ``rte_dma_conf`` structure is updated to include a new > >>>> field > >>>> + ``rte_dma_conf::flags`` that should be used to configure dmadev > >>>> features. > >>>> + The existing field ``rte_dma_conf::enable_silent`` is removed and > >>>> replaced > >>>> + with the new flag ``RTE_DMA_CFG_FLAG_SILENT``, to configure silent > >>>> mode > >>>> + the flag should be set in ``rte_dma_conf::flags`` during device > >>>> configuration. > >>>> > >>>> Acked-by: Amit Prakash Shukla <amitpraka...@marvell.com> > >>> > >>> There is only 1 ack. > >>> Per our policy, it will miss the release 25.07. > >>> > >>> You can probably do this change anyway, > >>> and keep ABI compatibility by versioning the function. > >> > >> Hi Fengchengwen, > >> > >> Are you ok with this change? If so please ack it so that I can work on > >> getting > >> an exception from techboard to merge this without deprecation notice in > >> 25.11. > >> > >> Thanks, > >> Pavan.
