On Mon, Sep 29, 2025 at 08:53:13PM +0100, Shetty, Praveen wrote: > > On Tue, Sep 23, 2025 at 02:54:54PM +0200, Shetty, Praveen wrote: > > From: Praveen Shetty <[email protected]> > > > > A "configuration queue" is a software term to denote a hardware > > mailbox queue dedicated to NSS programming. > > While the hardware does not have a construct of a "configuration > > queue", software does to state clearly the distinction between a > > queue software dedicates to regular mailbox processing (e.g. CPChnl > > or > > Virtchnl) and a queue software dedicates to NSS programming (e.g. > > SEM/LEM rule programming). > > > > Please provide expansions or clarifications for the acronyms used in the > commit message, so that the commit log is understandable for those unaware of > what the NSS is, or what SEM/LEM refers to. As far as I know, these are not > generally known terms in the industry. > >> Sure - will address this in v4. > > Also, you say that the hardware doesn't have a config queue, but software > does - I think that needs a bit of explanation as to what exactly the patch > is doing/implementing? How is software providing a special config queue if > the facility is not provided by HW. > > >> From the HW perspective, both mailbox and the config queues are "control" > >> queues. > >> For HW, "opcode" in the queue descriptor is one of the key differentiating > >> factors between mailbox queues and the config queues(operation code is > >> different for mailbox queues and the config queues). > >> Mailbox queues are used for Virtchnl and the CPChnl communication between > >> the driver and the FW. > >> Config queues are used for programming the FXP pipeline(Flexible packet > >> processor). > >> This patch will request for the queues from the fw using add_queue > >> virtchnl message and configures it as a config queue. > >> vCPF driver will then use this config queues to program the FXP pipeline > >> using rte_flow. > >> will add this information in the v4. >
Please provide more details like this in the revised commit log. Doesn't need to be fully this, but maybe a summary of it. >> Sure, thanks Bruce! Thanks, /Bruce
