> Not sure, what would it look like.

There is multiple ways, how about the one below.

> Having special case args for test looks like a kludge anyway.

100% agree, but it's not like we can easily fix it right now.


diff --git a/app/test/suites/meson.build b/app/test/suites/meson.build
index 4c815ea097..84da5e6d0e 100644
--- a/app/test/suites/meson.build
+++ b/app/test/suites/meson.build
@@ -99,22 +99,20 @@ foreach suite:test_suites
                 test_args += ['-d', dpdk_drivers_build_dir]
             endif
 
+            if test_name.endswith('_with_traces')
+                if is_windows
+                    continue
+                endif
+                test_args += ['--trace=.*']
+                test_args += 
['--trace-dir=@0@'.format(meson.current_build_dir())]
+            endif
+
             test(test_name, dpdk_test,
                 args : test_args,
                 env: ['DPDK_TEST=' + test_name],
                 timeout : timeout_seconds_fast,
                 is_parallel : false,
                 suite : 'fast-tests')
-            if not is_windows and test_name == 'trace_autotest'
-                test_args += ['--trace=.*']
-                test_args += 
['--trace-dir=@0@'.format(meson.current_build_dir())]
-                test(test_name + '_with_traces', dpdk_test,
-                    args : test_args,
-                    env: ['DPDK_TEST=' + test_name],
-                    timeout : timeout_seconds_fast,
-                    is_parallel : false,
-                    suite : 'fast-tests')
-            endif
         endforeach
     endif
 endforeach
diff --git a/app/test/test_trace.c b/app/test/test_trace.c
index 97dc69f68c..451d87bd16 100644
--- a/app/test/test_trace.c
+++ b/app/test/test_trace.c
@@ -255,3 +255,4 @@ test_trace(void)
 #endif /* !RTE_EXEC_ENV_WINDOWS */
 
 REGISTER_FAST_TEST(trace_autotest, NOHUGE_OK, ASAN_OK, test_trace);
+REGISTER_FAST_TEST(trace_autotest_with_traces, NOHUGE_OK, ASAN_OK, test_trace);

Reply via email to