On Thu, 22 Jan 2026 08:27:11 +0100 [email protected] wrote: > From: Martin Spinler <[email protected]> > > This series implements real multiport for better user experience. > > The existing driver creates one ethdev/port for one PCI device. > As the CESNET-NDK based cards aren't capable to represent each > Ethernet port by own PCI device, new driver implementation > processes real port configuration from firmware/card and switches > from rte_eth_dev_pci_generic_probe to multiple rte_eth_dev_create calls. > > ---
Wading through all the AI review... Things you should fix: - make sure all calls to snprintf() have overflow checks - clarity about what should be backported (Fixes/stable) - make sure all calls to rte_malloc et al have checks for NULL Things you could fix: - using malloc vs rte_malloc for data structures not shared not a big issue; but feel free to change. - avoiding code duplication - check prefix of global variables - mark driver only API's as __rte_internal Things I can fix when merging: - am willing to reword commit messages for readability as needed Things I don't care about: - release notes only have to be right after series, no need for per-patch - looks like all new functions are internal only, not sure why review wants tests. - assume 64 bit port mask is a hardware limit, you won't go over in future. - driver internal structures do not need doxygen comments - don't care about any AI warnings like "if you change X in the future it will break"
