Hello, On Mon, 23 Mar 2026 at 12:58, Marat Khalili <[email protected]> wrote: > Should we only fix those at the end of a function? Other cases may not cause > issues immediately, but may still confuse compilers and readers in the future. > > We are using the following hot-patch command in our CI: > > ```bash > sed -r 's/\bCHECK\(0, (\w+)\)/return -\1/g' -i lib/pipeline/rte_swx_pipeline.c > ``` > > And it performs 6 replacements.
Yep, I did this on purpose: I fixed what was breaking compilation. The other cases are not strictly wrong. Usage of this macro seemed intentional (for consistency?) so I did not touch the rest. -- David Marchand
