Remove unnecessary if check before calling rte_free
and rte_pktmbuf_free_bulk.

Generated by devtools/cocci/null_free.cocci

Signed-off-by: Stephen Hemminger <[email protected]>
---
 app/test-compress-perf/comp_perf_test_common.c | 6 ++----
 app/test-compress-perf/main.c                  | 6 ++----
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/app/test-compress-perf/comp_perf_test_common.c 
b/app/test-compress-perf/comp_perf_test_common.c
index 12c2a7bbd0..90eb98166e 100644
--- a/app/test-compress-perf/comp_perf_test_common.c
+++ b/app/test-compress-perf/comp_perf_test_common.c
@@ -83,11 +83,9 @@ comp_perf_free_memory(struct comp_test_data *test_data,
 {
        uint32_t i;
 
-       if (mem->decomp_bufs != NULL)
-               rte_pktmbuf_free_bulk(mem->decomp_bufs, mem->total_bufs);
+       rte_pktmbuf_free_bulk(mem->decomp_bufs, mem->total_bufs);
 
-       if (mem->comp_bufs != NULL)
-               rte_pktmbuf_free_bulk(mem->comp_bufs, mem->total_bufs);
+       rte_pktmbuf_free_bulk(mem->comp_bufs, mem->total_bufs);
 
        rte_free(mem->decomp_bufs);
        rte_free(mem->comp_bufs);
diff --git a/app/test-compress-perf/main.c b/app/test-compress-perf/main.c
index c9ead02cb4..bc2b185da4 100644
--- a/app/test-compress-perf/main.c
+++ b/app/test-compress-perf/main.c
@@ -392,15 +392,13 @@ comp_perf_dump_dictionary_data(struct comp_test_data *td)
 
                if (fread(data, data_to_read, 1, f) != 1) {
                        RTE_LOG(ERR, USER1, "Input file could not be read\n");
-                       if (td->dictionary_data)
-                               rte_free(td->dictionary_data);
+                       rte_free(td->dictionary_data);
                        goto end;
                }
                if (fseek(f, 0, SEEK_SET) != 0) {
                        RTE_LOG(ERR, USER1,
                                "Size of input could not be calculated\n");
-                       if (td->dictionary_data)
-                               rte_free(td->dictionary_data);
+                       rte_free(td->dictionary_data);
                        goto end;
                }
                remaining_data -= data_to_read;
-- 
2.53.0

Reply via email to