NACK
The srcs / dsts may be NULL if setup_memory_env() failed.
On 5/9/2026 4:33 AM, Stephen Hemminger wrote:
> Remove unnecessary if check before calling rte_pktmbuf_free_bulk.
>
> Generated by devtools/cocci/null_free.cocci
>
> Signed-off-by: Stephen Hemminger <[email protected]>
> ---
> app/test-dma-perf/benchmark.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c
> index c0ffc859bd..576c59faff 100644
> --- a/app/test-dma-perf/benchmark.c
> +++ b/app/test-dma-perf/benchmark.c
> @@ -690,10 +690,8 @@ teardown_memory_env(uint32_t nr_buf, struct rte_mbuf
> **srcs, struct rte_mbuf **d
> struct rte_dma_op **dma_ops)
> {
> /* free mbufs used in the test */
> - if (srcs != NULL)
> - rte_pktmbuf_free_bulk(srcs, nr_buf);
> - if (dsts != NULL)
> - rte_pktmbuf_free_bulk(dsts, nr_buf);
> + rte_pktmbuf_free_bulk(srcs, nr_buf);
> + rte_pktmbuf_free_bulk(dsts, nr_buf);
>
> /* free the points for the mbufs */
> rte_free(srcs);
